FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: added missing openFile method in ios utils by vakrilov · Pull Request #7431 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix: added missing openFile method in ios utils #7431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vakrilov merged 3 commits into from
Aug 1, 2019
Conversation 5 Commits 3 Checks 0 Files changed
Merged

fix: added missing openFile method in ios utils #7431

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3c3356
fix: added missing openFile method in ios utils
Jun 28, 2019
00a5ee1
chore: deprecate utils.ios.openFile
Jul 25, 2019
87ac88c
Merge branch 'master' into open-file
dtopuzov Aug 1, 2019
File filter

Filter by extension

Filter by extension .ts  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
35 changes: 22 additions & 13 deletions tns-core-modules/utils/utils.ios.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -89,20 +89,9 @@ export module ios {
export const MajorVersion = NSString.stringWithString(UIDevice.currentDevice.systemVersion).intValue;

export function openFile(filePath: string): boolean {
try {
const appPath = getCurrentAppPath();
const path = filePath.replace("~", appPath);
console.log("utils.ios.openFile() is deprecated; use utils.openFile() instead");

const controller = UIDocumentInteractionController.interactionControllerWithURL(NSURL.fileURLWithPath(path));
controller.delegate = new UIDocumentInteractionControllerDelegateImpl();

return controller.presentPreviewAnimated(true);
}
catch (e) {
traceWrite("Error in openFile", traceCategories.Error, traceMessageType.error);
}

return false;
return openFileAtRootModule(filePath);
}

export function getCurrentAppPath(): string {
Expand Down Expand Up @@ -146,6 +135,26 @@ export module ios {

}

export function openFile(filePath: string): boolean {
try {
const appPath = ios.getCurrentAppPath();
const path = filePath.replace("~", appPath);

const controller = UIDocumentInteractionController.interactionControllerWithURL(NSURL.fileURLWithPath(path));
controller.delegate = new UIDocumentInteractionControllerDelegateImpl();

return controller.presentPreviewAnimated(true);
}
catch (e) {
traceWrite("Error in openFile", traceCategories.Error, traceMessageType.error);
}

return false;
}

// Need this so that we can use this function inside the ios module (avoid name clashing).
const openFileAtRootModule = openFile;

export function GC() {
__collect();
}
Expand Down
Back | FazBrowse Home | New Git URL