FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(tabs-ios): unable to return to tab after tab with nested frame visited by ADjenkov · Pull Request #7574 · NativeScript/NativeScript · GitHub

fix(tabs-ios): unable to return to tab after tab with nested frame visited - #7574

Merged
SvetoslavTsenov merged 26 commits into
releasefrom
djenkov/preload-ios-tabs
Jul 25, 2019
Merged

SvetoslavTsenov merged 26 commits into
releasefrom
djenkov/preload-ios-tabs

Conversation

ADjenkov commented Jul 24, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Postpone load/unload until UIPageViewController animation between 'pages' completes
Note: If nested frame available inside TabContentItem, it will be shown just after animation completes.

Includes rebase of mdonev/tabs-bottom-nav-e2e branch

Fix #7564

ADjenkov self-assigned this Jul 24, 2019
cla-bot Bot added the cla: yes label Jul 24, 2019

Copy link
Copy Markdown
Contributor Author

test --ignore branch-nested-frame-navigation#mdonev/tabs-bottom-nav-e2e api23 ios12 uitests

ADjenkov force-pushed the djenkov/preload-ios-tabs branch from 9638f37 to 4cb8041 Compare July 24, 2019 14:46
SvetoslavTsenov merged commit 490cab0 into release Jul 25, 2019
SvetoslavTsenov deleted the djenkov/preload-ios-tabs branch July 25, 2019 12:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL