feat(tab-content-view): change tabContentItem to View - #7629
Merged
MartoYankov merged 9 commits intoAug 15, 2019
Merged
MartoYankov merged 9 commits into
MartoYankov merged 9 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MartoYankov
approved these changes
Aug 2, 2019
ADjenkov
force-pushed
the
djenkov/tab-content-item-view
branch
from
206e183 to
2cd39a4
Compare
August 7, 2019 11:10
ADjenkov
force-pushed
the
djenkov/tab-content-item-view
branch
from
25754f9 to
66bbf21
Compare
August 7, 2019 11:41
MartoYankov
approved these changes
Aug 13, 2019
manoldonev
approved these changes
Aug 14, 2019
tsonevn
pushed a commit
that referenced
this pull request
Sep 2, 2019
chore: update changelog add keyboard's backspace click event listener fix tslint errors fix tsc errors add keyboard's backspace click event listener fix tslint errors fix tsc errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewersAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make tabContentItem ContentView instead of ViewBase to enable CSS properties propagation. This will enable setting backgroundColor/color and so on to its children views.
Modify Tabs,BottomNavigation and tests to respect ContentVIew's content property.
FIx #7496