fix: dots can now be used in module names - #7655
Merged
SvetoslavTsenov merged 3 commits intoAug 20, 2019
Merged
SvetoslavTsenov merged 3 commits into
SvetoslavTsenov merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Only known extensions are stripped from the end of module names
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
manoldonev
approved these changes
Aug 20, 2019
Copy link
Copy Markdown
Contributor
|
test --ignore ngapps api24 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
If you have a module name with a dot in it, the code fails
What is the new behavior?
Only pre-defined extensions are stripped from the end of module names
Fixes #7646