FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(dark-mode): add system appearance property, event and CSS classes by vchimev · Pull Request #7887 · NativeScript/NativeScript · GitHub

  1. NativeScript
  2. NativeScript

Repository navigation

feat(dark-mode): add system appearance property, event and CSS classes - #7887

Merged
manoldonev merged 19 commits into
masterfrom
vchimev/system-mode
Oct 8, 2019
ConversationCommits (19)ChecksFiles changed
Merged

feat(dark-mode): add system appearance property, event and CSS classes#7887
manoldonev merged 19 commits into
masterfrom
vchimev/system-mode

Conversation

vchimev commented Oct 1, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Checklist

Implements

  • Detect system appearance at application launch:
    expose a systemAppearance property to the application module,
  • Add ns-light/ns-dark CSS classes to the application root view,
  • Notify about a system appearance change:
    expose a systemAppearanceChanged event

of #7800.

cla-bot Bot added the cla: yes label Oct 1, 2019
vchimev requested review from MartoYankov, manoldonev and vakrilov and removed request for MartoYankov and manoldonev October 1, 2019 08:25
vchimev changed the title feat(dark-mode): apply ns-light|ns-dark CSS classes to the application root view feat(dark-mode): add ns-light|ns-dark CSS classes to the application root view Oct 1, 2019
vchimev requested review from ADjenkov and MartoYankov and removed request for vakrilov October 1, 2019 08:28
vchimev force-pushed the vchimev/system-mode branch from 15bec02 to d81be71 Compare October 3, 2019 05:17
vchimev mentioned this pull request Oct 3, 2019
Open
4 of 12 tasks
vchimev changed the title feat(dark-mode): add ns-light|ns-dark CSS classes to the application root view feat(dark-mode): add system appearance property, event and CSS classes Oct 3, 2019
manoldonev reviewed Oct 3, 2019
View reviewed changes
Comment thread tns-core-modules/application/application.d.ts Outdated
manoldonev reviewed Oct 4, 2019
View reviewed changes
Comment thread tns-core-modules/ui/core/view/view.ios.ts Outdated
manoldonev reviewed Oct 4, 2019
View reviewed changes
Comment thread tns-core-modules/ui/frame/frame.ios.ts Outdated
manoldonev reviewed Oct 4, 2019
View reviewed changes
Comment thread tns-core-modules/ui/page/page.ios.ts Outdated
manoldonev reviewed Oct 4, 2019
View reviewed changes
Comment thread tns-core-modules/ui/tab-view/tab-view.ios.ts Outdated
manoldonev reviewed Oct 4, 2019
View reviewed changes
Comment thread tns-core-modules/ui/tabs/tabs.ios.ts Outdated
vchimev force-pushed the vchimev/system-mode branch from b276a1c to 20594c1 Compare October 4, 2019 14:15
vchimev requested a review from manoldonev October 4, 2019 14:16
manoldonev approved these changes Oct 4, 2019
View reviewed changes

manoldonev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

After addressing last comment.

vchimev added 18 commits October 4, 2019 19:04
feat(system-classes): reset root view classes
3f9091f
feat(dark-mode): apply ns-dark|ns-light class to root view at app launch
efd72f8
refactor: deprecate an interface
1438a01
feat(ios): add traitCollectionDidChange to controllers
348c7dc
feat(ios): expose traitCollectionColorAppearanceChangedEvent
ec45e81
feat(ios): add setupRootViewCssClasses function
72e8051
feat(dark-mode): respect traitCollectionColorAppearanceChanged event
c7b2ff8
feat: add UserInterfaceStyle enum
7043f78
refactor(dark-mode): application module
ae241af
refactor(dark-mode): delete console logs
5173f28
feat(mode-night): apply ns-dark|ns-light class to root view at app la…
e91cee3 
…unch
feat: expose system appearance to application module
f0249b9
refactor: address comments
65365c8
refactor: application events attachment
2962587 
This is because could not synchronize attachment in:
- application module,
- user's application.

Do not attach on orientation changed and system appearance changed events.
Insted, execute logic before notifying the registered listeners for the event.
refactor: check if weak refs exist
3a9e63f
refactor: add a comment to all controllers
3aeb24f
refactor: add a comment on embedding to native apps
5243fa3
refactor: add a comment
10edbfc
vchimev force-pushed the vchimev/system-mode branch from 20594c1 to 10edbfc Compare October 4, 2019 16:04
manoldonev merged commit 5c9a217 into master Oct 8, 2019
manoldonev deleted the vchimev/system-mode branch October 8, 2019 10:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MartoYankov Awaiting requested review from MartoYankov
ADjenkov Awaiting requested review from ADjenkov
1 more reviewer
manoldonev manoldonev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL