FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: UIUserInterfaceStyle is undefined for iOS <= 11 by vchimev · Pull Request #7931 · NativeScript/NativeScript · GitHub

  1. NativeScript
  2. NativeScript

Repository navigation

fix: UIUserInterfaceStyle is undefined for iOS <= 11 - #7931

Merged
manoldonev merged 10 commits into
masterfrom
vchimev/dark-mode/fixes
Oct 16, 2019
ConversationCommits (10)ChecksFiles changed
Merged

fix: UIUserInterfaceStyle is undefined for iOS <= 11#7931
manoldonev merged 10 commits into
masterfrom
vchimev/dark-mode/fixes

Conversation

vchimev commented Oct 9, 2019

Copy link
Copy Markdown
Contributor

PR Checklist

Fix that UIUserInterfaceStyle is undefined for iOS <= 11.
Add tests for the system appearance property and system appearance root view CSS classes.

Relates to #7800.

cla-bot Bot added the cla: yes label Oct 9, 2019

MartoYankov commented Oct 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

The property userInterfaceStyle doesn't exist on UITraitCollection before iOS 12. This isn't obvious in the code. I think it would be more obvious if you check for major version at the beginning of the systemAppearance getter and if < 12 return light or undefined explicitly. Maybe null is better than undefined.

vchimev force-pushed the vchimev/dark-mode/fixes branch from 5a21341 to fef9776 Compare October 10, 2019 08:02

SvetoslavTsenov commented Oct 11, 2019

Copy link
Copy Markdown
Contributor

test --ignore cuteness uitests#vchimev/dark-mode/fixes ios10 ios11 ios12 ios13

dtopuzov commented Oct 15, 2019

Copy link
Copy Markdown
Contributor

test --ignore cuteness uitests#vchimev/dark-mode/fixes ios10 ios11 ios12 ios13

manoldonev commented Oct 16, 2019

Copy link
Copy Markdown
Contributor

test --ignore cuteness uitests#vchimev/dark-mode/fixes ios10 ios11 ios12 ios13

manoldonev merged commit 6c71394 into master Oct 16, 2019
manoldonev deleted the vchimev/dark-mode/fixes branch October 16, 2019 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
manoldonev manoldonev approved these changes
MartoYankov MartoYankov approved these changes
vakrilov vakrilov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

vchimev

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL