FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(dialogs): Setting the size of popup dialog thru dialog options by slolam · Pull Request #8041 · NativeScript/NativeScript · GitHub

  1. NativeScript
  2. NativeScript

Repository navigation

feat(dialogs): Setting the size of popup dialog thru dialog options - #8041

Merged
vakrilov merged 14 commits into
NativeScript:masterfrom
slolam:ios-dialog-size
Dec 5, 2019
ConversationCommits (14)ChecksFiles changed
Merged

feat(dialogs): Setting the size of popup dialog thru dialog options#8041
vakrilov merged 14 commits into
NativeScript:masterfrom
slolam:ios-dialog-size

Conversation

slolam commented Oct 31, 2019 •
edited by vakrilov
Loading

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

There is no way to set the size of the popup dialog on iOS

What is the new behavior?

This will allow to size the popup dialogs in iOS (primarily iPad based apps, for iPhone apps iOS ignores these properties). Here is the playground project to test https://play.nativescript.org/?template=play-ng&id=GeR8Q4&v=3

cla-bot Bot added the cla: yes label Oct 31, 2019
vakrilov self-requested a review November 25, 2019 16:14
vakrilov changed the title feat(iOS popup dialog size): Setting the size of popup dialog thru dialog options feat(dialogs): Setting the size of popup dialog thru dialog options Dec 2, 2019

vakrilov commented Dec 2, 2019

Copy link
Copy Markdown
Contributor

test

slolam commented Dec 2, 2019

Copy link
Copy Markdown
Contributor Author

@vakrilov, how do I get to see the logs/details of the tests failed? By clicking on details, it is looking for nsbuild01.telerik.com which seems to be a internal DNS entry.

vakrilov commented Dec 3, 2019

Copy link
Copy Markdown
Contributor

Hey @slolam
Can you please run npm run api-extractor in the root of the repo and then commit the changes in the NativeScript.api.md file. This is needed because this PR is changing the public API of the framework.

This should make the travis build green.

slolam commented Dec 3, 2019

Copy link
Copy Markdown
Contributor Author

Hey @vakrilov,

sh: api-extractor: command not found it looks like I am missing some dependencies

cla-bot Bot commented Dec 3, 2019

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Shailesh Lolam.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

slolam commented Dec 3, 2019

Copy link
Copy Markdown
Contributor Author

@vakrilov, never mind I did not update the npm packages. I have committed the NativeScript.api.md

cla-bot Bot commented Dec 3, 2019

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Shailesh Lolam.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot Bot commented Dec 3, 2019

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Shailesh Lolam.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

vakrilov commented Dec 3, 2019

Copy link
Copy Markdown
Contributor

test

vakrilov commented Dec 4, 2019

Copy link
Copy Markdown
Contributor

Hey @slolam
Seems that the CLA bot is not satisfied any more (this might happen if you have changed you git config settings or if you have pushed a commit from another machine). Can you try signing the CLA again?

cla-bot Bot commented Dec 4, 2019

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Shailesh Lolam.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

slolam commented Dec 4, 2019

Copy link
Copy Markdown
Contributor Author

@vakrilov, yes, I have committed from a different machine earlier. I committed again from the previous machine but still the CLA bot has hung up previous commit that had issue. Not sure how you want me to undo my previous commit. Could you please help me with this?

cla-bot Bot commented Dec 5, 2019

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Shailesh Lolam.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot Bot commented Dec 5, 2019

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Shailesh Lolam.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

dtopuzov commented Dec 5, 2019

Copy link
Copy Markdown
Contributor

test

vakrilov commented Dec 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tests are green. I've checked the CLA seems to be OK. Thanks @slolam !
Merging.

vakrilov merged commit cd5703a into NativeScript:master Dec 5, 2019

slolam commented Dec 5, 2019

Copy link
Copy Markdown
Contributor Author

Thanks @vakrilov for your help !

slolam deleted the ios-dialog-size branch December 5, 2019 16:09
rynop pushed a commit to rynop/NativeScript that referenced this pull request Dec 6, 2019
feat(dialogs): Setting the size of popup dialog thru dialog options (N…
d5cc264 
…ativeScript#8041)

* Added iOS specific height and width attributes to ShowModalOptions

* Set the height and width of the popup dialog to the presenting controller

* dialog options ios attributes presentationStyle, height & width are made optional

* Updated NativeScript.api.md for public API changes

* Update with git properties

* Public API

* CLA update
vakrilov added a commit that referenced this pull request Jan 10, 2020
feat: Add 3D rotation to view - takeover of PR# 5950 (#8136)
e8f5ac8 
* feat: add 3d rotation

* chore: fix build errors

* chore: fix tslint errors

* chore: add @types/chai dev dep

* chore: unused import cleanup

* chore: update tests for x,y rotation

* chore: rebase upstream/master

* fix: iOS Affine Transform test verification

* feat(css): Added optional css-tree parser (#8076)

* feat(css): Added optional css-tree parser

* test: css-tree parser compat tests

* test: more css-tree compat tests

* feat(dialogs): Setting the size of popup dialog thru dialog options (#8041)

* Added iOS specific height and width attributes to ShowModalOptions

* Set the height and width of the popup dialog to the presenting controller

* dialog options ios attributes presentationStyle, height & width are made optional

* Updated NativeScript.api.md for public API changes

* Update with git properties

* Public API

* CLA update

* fix: use iOS native-helper for 3d-rotate

* test: Fix tests using _getTransformMismatchError

* fix: view.__hasTransfrom not set updating properly

* test: fix css-animations test page

Co-authored-by: Alexander Vakrilov <alexander.vakrilov@gmail.com>
Co-authored-by: Darin Dimitrov <darin.dimitrov@gmail.com>
Co-authored-by: Shailesh Lolam <slolam@live.com>
Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com>
snyk-bot mentioned this pull request Feb 26, 2020
Closed
This was referenced Mar 20, 2020
Merged
Closed
Merged
This was referenced Apr 9, 2020
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
vakrilov vakrilov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL