Repository navigation
Add 3d rotation to View - takeover of PR# 5950 - #8135
Closed
rynop wants to merge 31 commits into
Closed
rynop wants to merge 31 commits into
rynop wants to merge 31 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Merge branch 'master' into master
Copy link
Copy Markdown
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Hamdi Wanis.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
This is an attempted takeover for stalled #5950 . Until this PR, NS only supports rotation around the Z axis.
What is the new behavior?
View can now rotate around x, y or z axis.
Fixes/Implements/Closes #[Issue Number].
#5950
BREAKING CHANGES:
Need some help here. 3d graphics is not my area of expertise.