Repository navigation
feat: TappableSpan support - #8256
Merged
vtrifonov merged 12 commits intoMar 20, 2020
Merged
vtrifonov merged 12 commits into
vtrifonov merged 12 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Initial support for clickable span on Android
3 of 5 tasks
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
vmutafov
approved these changes
Mar 20, 2020
vtrifonov
added a commit
that referenced
this pull request
Mar 20, 2020
* feat(android): clickable span Initial support for clickable span on Android * test: clickable-span test page * remove console.log * use _emit instead of notify * rename clickable to tappable in Span * updated NativeScript.api.md * chore: fixing tslint errors * chore: fixed witespacing * moved and improved test page * feat: tappable span iOS implementation Co-authored-by: Eduardo Speroni <edusperoni@gmail.com>
3 of 5 tasks
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
* feat(android): clickable span Initial support for clickable span on Android * test: clickable-span test page * remove console.log * use _emit instead of notify * rename clickable to tappable in Span * updated NativeScript.api.md * chore: fixing tslint errors * chore: fixed witespacing * moved and improved test page * feat: tappable span iOS implementation Co-authored-by: Eduardo Speroni <edusperoni@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the #7076 PR to can be merged in master
PR Checklist
What is the current behavior?
There is no way to add links to Labels/TextViews.
What is the new behavior?
Span now has a linkTap event which, when bound, makes it possible for it to be interacted with via tap.
Implements #3671.