FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

placeholder creatingView event fixed + tests by enchev · Pull Request #846 · NativeScript/NativeScript · GitHub

/ NativeScript Public

placeholder creatingView event fixed + tests - #846

Merged
enchev merged 1 commit into
masterfrom
placeholder-event-fix
Sep 30, 2015
ConversationCommits (1)ChecksFiles changed
Merged

placeholder creatingView event fixed + tests#846
enchev merged 1 commit into
masterfrom
placeholder-event-fix

Conversation

enchev commented Sep 29, 2015

Copy link
Copy Markdown
Contributor

Fixed #772

ns-bot added cla: yes and removed cla: no labels Sep 29, 2015

hshristov commented Sep 29, 2015

Copy link
Copy Markdown
Contributor

👍

atanasovg commented Sep 29, 2015

Copy link
Copy Markdown
Contributor

I remember @hamorphis changed this on purpose (it actually was a requested fix). Here is his fix.

enchev commented Sep 30, 2015

Copy link
Copy Markdown
Contributor Author

Actually @hshristov resolved the crash with measure in other place and now we can remove this safely in my opinion.

[UPDATE]. We still have problem with measure if we do not provide native view. I'll check how to solve this!

enchev commented Sep 30, 2015

Copy link
Copy Markdown
Contributor Author

We've decided to measure views no matter if they have native view
or not.

enchev force-pushed the placeholder-event-fix branch from 571f967 to f60230f Compare September 30, 2015 08:05

dtopuzov commented Sep 30, 2015

Copy link
Copy Markdown
Contributor

run ci

enchev force-pushed the placeholder-event-fix branch from f60230f to 113a1b6 Compare September 30, 2015 08:27

ns-bot commented Sep 30, 2015

Copy link
Copy Markdown

Test PASSed.

hamorphis commented Sep 30, 2015

Copy link
Copy Markdown
Contributor

👍

enchev pushed a commit that referenced this pull request Sep 30, 2015
Merge pull request #846 from NativeScript/placeholder-event-fix
27fc11b 
placeholder creatingView event fixed + tests
enchev merged commit 27fc11b into master Sep 30, 2015
enchev deleted the placeholder-event-fix branch September 30, 2015 10:35

lock Bot commented Aug 29, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Placeholder with an id attribute doesn't call creatingView handler

6 participants

Back | FazBrowse Home | New Git URL