Repository navigation
fix(android): BottomNavigation fragment child already has a parent - #9148
Merged
NathanWalker merged 2 commits intoJan 17, 2021
Merged
NathanWalker merged 2 commits into
NathanWalker merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
rigor789
previously approved these changes
Jan 17, 2021
rigor789
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good to me, though I think we could clean up the nesting a little bit to make it a bit easier to follow/read, and perhaps debug when necessary.
Left some suggestions to change var to const, but regardless this looks fine to merge. 🚀
Sorry, something went wrong.
Comment thread
packages/core/ui/bottom-navigation/index.android.ts
Outdated
Comment thread
packages/core/ui/bottom-navigation/index.android.ts
Outdated
Comment thread
packages/core/ui/bottom-navigation/index.android.ts
Outdated
rigor789
added a commit
that referenced
this pull request
Jan 20, 2021
* chore(release): @nativescript/core@7.1.1 * feat(core): rollup additional Utils * fix(webpack): support other workspace config styles * chore(release): @nativescript/core@7.1.2 * fix(android): BottomNavigation fragment child already has a parent (#9148) closes #8132 closes #7901 closes #9051 closes #8251 * chore(release): @nativescript/core@7.1.3 * types: missing typings for iosIgnoreSafeArea (#9153) * Update build-docs.sh Co-authored-by: Nathan Walker <walkerrunpdx@gmail.com> Co-authored-by: Martin Guillon <martin.guillon@akylas.fr>
Copy link
Copy Markdown
|
any fix for ns 6? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Android BottomNavigation was super fragile, prone to bugs and race conditions due to poor fragment handling.
What is the new behavior?
Android BottomNavigation is stable and reliable.
closes #8132
closes #7901
closes #9051
closes #8251