FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(webgpu): expose GPUQuerySet.destroy by LorenzGit · Pull Request #145 · NativeScript/canvas · GitHub

Repository navigation

fix(webgpu): expose GPUQuerySet.destroy - #145

Merged
triniwiz merged 1 commit into
NativeScript:masterfrom
LorenzGit:contrib/gpu-query-destroy
Sep 9, 2026
Merged

triniwiz merged 1 commit into
NativeScript:masterfrom
LorenzGit:contrib/gpu-query-destroy

Conversation

LorenzGit commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Expose GPUQuerySet.destroy() through the TypeScript wrapper so callers can release the native query resource.

Validation

The focused wrapper test passed, and the final tvOS simulator integration test creates and destroys a real query set. Independent of tvOS.

Reproduce

Revision-pinned reviewer setup builds the companion stack in an isolated workspace. It includes commands, requirements, dependency pins and physical-device limitations. No binary artifacts or private development paths are committed.

This PR contains one commit, cfe0b9de68ee97c3b51cc59cd530f9c2455af664, changing 1 files against 1fd6ef470dfdfd43b3385fa7ef43feddd1debd06. Its exported patch reproduces the committed tree from a fresh base index.

The source-built runtime was validated in the prepared runtime checkout; companion clones, native helpers, Canvas and clean npm installation were validated in a separate workspace on the same Mac. A second machine and one uninterrupted cold all run have not been tested.

coderabbitai Bot commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 9fa137e4-a684-446a-ade2-37978ceb9519

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL