Repository navigation
fix(webgpu): progress buffer mappings without a render loop - #148
triniwiz merged 1 commit into
Conversation
Sorry, something went wrong.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 29bd2ab2-ff49-4bf7-a2cb-a99b6420b28f You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file. Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
Compute-only WebGPU workloads can wait forever in GPUBuffer.mapAsync() because wgpu mapping callbacks require polling. Service polling on one background worker and initialize the Apple promise callback payload.
Validation
The native regression submits compute work, reads back 42, remaps without another submission or frame, and rejects an invalid range. Both tvOS native slices rebuilt and the exact committed spec passed in the source-built simulator runtime. No WebGPU canvas or render loop is created. Android/device execution was not rerun; the fix is independent of tvOS.
Reproduce
Revision-pinned reviewer setup builds the companion stack in an isolated workspace. It includes commands, requirements, dependency pins and physical-device limitations. No binary artifacts or private development paths are committed.
This PR contains one commit, 1bd9e03474e53ecf45d3f38e05db3847f7439b48, changing 3 files against 1fd6ef470dfdfd43b3385fa7ef43feddd1debd06. Its exported patch reproduces the committed tree from a fresh base index.
The source-built runtime was validated in the prepared runtime checkout; companion clones, native helpers, Canvas and clean npm installation were validated in a separate workspace on the same Mac. A second machine and one uninterrupted cold all run have not been tested.