FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: Update SDK root in README by goonerify · Pull Request #1939 · NativeScript/docs-v7 · GitHub

This repository was archived by the owner on Nov 17, 2022. It is now read-only.
  1. NativeScript
  2. docs-v7

Repository navigation

docs: Update SDK root in README - #1939

Open
goonerify wants to merge 1 commit into
NativeScript:masterfrom
goonerify:patch-1
ConversationCommits (1)ChecksFiles changed
Open

docs: Update SDK root in README#1939
goonerify wants to merge 1 commit into
NativeScript:masterfrom
goonerify:patch-1

Conversation

goonerify commented Jan 23, 2021

Copy link
Copy Markdown

Command line tools path seems to have changed from $ANDROID_SDK_ROOT/cmdline-tools/tools to $ANDROID_SDK_ROOT/cmdline-tools/cmdline-tools

PR Checklist

What is the current state of the documentation article?

What is the new state of the documentation article?

Fixes/Implements/Closes #[Issue Number].

Update SDK root
b261a8e 
Command line tools path seems to have changed from $ANDROID_SDK_ROOT/cmdline-tools/tools to $ANDROID_SDK_ROOT/cmdline-tools/cmdline-tools

cla-bot Bot commented Jan 23, 2021

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @goonerify.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

goonerify commented Jan 23, 2021

Copy link
Copy Markdown
Author

@cla-bot check

cla-bot Bot added the cla: yes label Jan 23, 2021

cla-bot Bot commented Jan 23, 2021

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

goonerify changed the title Update SDK root in README docs: Update SDK root in README Jan 23, 2021

goonerify commented Jan 23, 2021

Copy link
Copy Markdown
Author

@cla-bot check

cla-bot Bot commented Jan 23, 2021

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

avats-dev reviewed Feb 14, 2021
View reviewed changes

avats-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hii @goonerify, this looks good. Although as your PR has just one commit, you need it to be a semantic commit to pass the checks. So I think there are two ways for avoiding this:

  • either someone merges this with the failing checks, depends on the reviewers and maintainers.
  • or you might add more commits (i.e. resolve more minor issues along with this PR). Just commit your changes and the PR will get updated by itself.

Please mention if there is any issue relevant to this PR to avoid duplicate works and save time. Thanks for contributing. 🎉

rigor789 commented Feb 15, 2021

Copy link
Copy Markdown
Member

The reason I haven't merged this yet, is that I couldn't confirm the path is correct - since both on Windows & macOS these don't exist (cmdline-tools) and are located at <SDK_ROOT>/tools/bin

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
avats-dev avats-dev left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL