feat: split long logs into multiple instead of truncating - #177
Draft
rigor789 wants to merge 2 commits into
Draft
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@rigor789 will the result of the splitted log be on the same line in the console? Like let s say it is a JSON.stringify which is splitted. Will you be able to copy it, paste it as a correct JSON string? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@rigor789 i am intersted in testing this. Any chance to have an alpha runtime with this? |
Sorry, something went wrong.
edusperoni
force-pushed
the
feat/large-log-chunking
branch
from
eb1368e to
f6282e6
Compare
July 4, 2023 16:04
Copy link
Copy Markdown
Collaborator
|
@farfromrefug once the build finishes you can get the .tgz from the artifacts here: https://github.com/NativeScript/ios/actions/runs/5456662035 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NSLog has a 1024 character limit, and anything beyond is truncated with <...>. This PR aims to split longer logs into multiple NSLog calls when necessary.
This is already possible on Android by setting the maxLogcatObjectSize boolean under the android key in the config.
The goal is to add a similar config option for iOS as well.
Todos:
closes NativeScript/NativeScript#8657