No actionable comments were generated in the recent review. 🎉

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 451295d8-0fe0-4952-b933-8a1768213d09

Reviewing files that changed from the base of the PR and between ebe32ac and 79a74fc.

• NativeScript/runtime/PromiseProxy.cpp
• TestRunner/app/tests/Promises.js

• TestRunner/app/tests/Promises.js

Walkthrough

Promise proxy installation now passes a runtime-loop callback into the embedded bootstrap, and promise resolve/reject/.then scheduling now checks the runtime loop before marshaling to another runloop. A new test covers background creation with main-queue settlement.

Changes

Promise proxy runtime-loop scheduling

Sequence Diagram(s)

sequenceDiagram
  participant PromiseProxy as "PromiseProxy.cpp"
  participant RuntimeLoop as "runtime->RuntimeLoop()"
  participant PerformBlock as "CFRunLoopPerformBlock"
  participant WakeUp as "CFRunLoopWakeUp"

  PromiseProxy->>RuntimeLoop: compare current CFRunLoop
  alt current thread matches runtime loop
    PromiseProxy->>PromiseProxy: invoke resolve/reject/.then synchronously
  else current thread differs
    PromiseProxy->>PerformBlock: queue callback on the captured runloop
    PromiseProxy->>WakeUp: wake the target runloop
  end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I hopped through loops of main-thread light,
Where promises now wake just right.
A background burrow met the day,
And settled values found their way.
🐇 Thump-thump—done!

❌ Failed checks (1 warning)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

• X
• Mastodon
• Reddit
• LinkedIn

Comment @coderabbitai help to get the list of available commands.

🧹 Nitpick comments (1)

TestRunner/app/tests/Promises.js (1)> 142-147: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Fail explicitly on unexpected rejection.
If this promise rejects, the test currently hangs until timeout, which obscures the failure. Add a catch that fails and completes the async spec.

Proposed test hardening

             new Promise(resolve => {
                 NSOperationQueue.mainQueue.addOperationWithBlock(() => resolve("settled"));
             }).then(value => {
                 expect(value).toBe("settled");
                 done();
+            }).catch(error => {
+                expect(true).toBe(false, `Promise rejected unexpectedly: ${error}`);
+                done();
             });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@TestRunner/app/tests/Promises.js` around lines 142 - 147, The Promise test in
the async spec currently only handles the success path, so unexpected rejection
can hang the test until timeout. Update the Promise chain in the `Promises.js`
test case to add a `catch` alongside the existing `then` so any rejection
explicitly fails the spec and calls `done()`. Keep the change focused on the
affected promise block near the
`NSOperationQueue.mainQueue.addOperationWithBlock` usage and the
`expect(value).toBe("settled")` assertion.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@TestRunner/app/tests/Promises.js`:
- Around line 142-147: The Promise test in the async spec currently only handles
the success path, so unexpected rejection can hang the test until timeout.
Update the Promise chain in the `Promises.js` test case to add a `catch`
alongside the existing `then` so any rejection explicitly fails the spec and
calls `done()`. Keep the change focused on the affected promise block near the
`NSOperationQueue.mainQueue.addOperationWithBlock` usage and the
`expect(value).toBe("settled")` assertion.

ℹ️ Review info

@coderabbitai, fixed now.

@adrian-niculescu Thanks for the update — marking this as addressed.

(ᵔᴥᵔ)

If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!

Tip

For best results, initiate chat on the files or code changes.

@adrian-niculescu Thanks for the update — marking this as addressed.

(ᵔᴥᵔ)

If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!

@coderabbitai, please approve the PR if there's nothing else to address.

@adrian-niculescu From my side, there’s nothing else left to address here — approving the PR.

Comments resolved. Approval is disabled; enable reviews.request_changes_workflow to allow explicit top-level @coderabbitai resolve or @coderabbitai approve commands.

Thank you!