fix(worker): throw when an environment-data key cannot be converted to a string by adrian-niculescu · Pull Request #492 · NativeScript/ios · GitHub

setEnvironmentData(key, value) with a key whose toString() throws does not throw. It stores the value under the empty-string key instead, replacing whatever was there, and getEnvironmentData(key) and setEnvironmentData(key) read or delete that unrelated entry.

Both callbacks convert the key with a helper that swallows a throwing toString() and returns an empty string. They now convert it with a checked ToString and return with the exception pending, so it reaches the caller. Keys stay stringified, as the shared stringifies keys spec expects. A symbol key now throws a TypeError, as any string conversion of a symbol does, rather than mapping to the empty-string key.

The same fix for Android is NativeScript/android#2066. The new spec fails on main and passes here, and the full TestRunner suite passes.

Summary by CodeRabbit

Bug Fixes
- Environment-data operations now correctly surface errors when converting a key to a string, instead of using an empty-string key.
Tests
- Added coverage for key-conversion errors and confirmed that existing empty-string entries remain unchanged.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 0180e9b1-a307-4c7c-96ba-93f5e30290f9

📥 Commits

Reviewing files that changed from the base of the PR and between 4ae32eb and 6da57c5.

📒 Files selected for processing (2)

NativeScript/runtime/Messaging.cpp
TestRunner/app/tests/MessagingTests.js

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

Walkthrough

Environment-data set and get callbacks now stop when key conversion fails. Tests verify that conversion exceptions propagate and that the empty-string entry remains unchanged.

Changes

Environment Data Key Conversion

Layer / File(s)	Summary
Checked key conversion NativeScript/runtime/Messaging.cpp, TestRunner/app/tests/MessagingTests.js	The set and get callbacks return when key conversion fails. Tests cover exceptions from key toString() methods and verify that the empty-string entry remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 6da57

The change is mergeable after normal checks; no unresolved behavior or data-integrity risk is established.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: propagate errors when an environment-data key cannot be converted to a string.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1 🛠️ Fix failing CI checks 💡

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit taps a key with care,
Its string throws; the error’s there.
Set and get now stop in place,
No empty key takes its space.
The old entry stays as found,
Then hopping tests run round and round.

Comment @coderabbitai help to get the list of available commands.

…o a string setEnvironmentData and getEnvironmentData converted the key with a helper that swallows a throwing toString() and returns an empty string, so such a key silently read, overwrote or deleted the unrelated empty-string entry. The conversion is checked now and the exception reaches the caller.

@coderabbitai review

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

adrian-niculescu mentioned this pull request Oct 6, 2026

fix(worker): throw when an environment-data key cannot be converted to a string NativeScript/android#2066

Open

adrian-niculescu marked this pull request as ready for review October 6, 2026 19:22

adrian-niculescu force-pushed the fix/environment-data-key-conversion branch from b0930d5 to 6da57c5 Compare October 6, 2026 19:24

adrian-niculescu mentioned this pull request Oct 6, 2026

fix(runtime): deliver a posted undefined as undefined, not null #477

Merged

fix(worker): throw when an environment-data key cannot be converted to a string by adrian-niculescu · Pull Request #492 · NativeScript/ios · GitHub

Repository navigation

fix(worker): throw when an environment-data key cannot be converted to a string - #492

fix(worker): throw when an environment-data key cannot be converted to a string#492
adrian-niculescu wants to merge 1 commit into
NativeScript:mainfrom
adrian-niculescu:fix/environment-data-key-conversion

adrian-niculescu commented Oct 6, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 6, 2026 •
edited
Loading

Uh oh!

Uh oh!

adrian-niculescu commented Oct 6, 2026

Uh oh!

coderabbitai Bot commented Oct 6, 2026 •
edited
Loading

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

fix(worker): throw when an environment-data key cannot be converted to a string by adrian-niculescu · Pull Request #492 · NativeScript/ios · GitHub

Repository navigation

fix(worker): throw when an environment-data key cannot be converted to a string - #492

Conversation

adrian-niculescu commented Oct 6, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

adrian-niculescu commented Oct 6, 2026

Uh oh!

coderabbitai Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

adrian-niculescu commented Oct 6, 2026 •
edited by coderabbitai Bot
Loading

coderabbitai Bot commented Oct 6, 2026 •
edited
Loading

coderabbitai Bot commented Oct 6, 2026 •
edited
Loading