FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor: remove http module by tgpetrov · Pull Request #1942 · NativeScript/nativescript-angular · GitHub

refactor: remove http module - #1942

Merged
tgpetrov merged 1 commit into
masterfrom
tgpetrov/remove-http-module
Aug 12, 2019
Merged

refactor: remove http module#1942
tgpetrov merged 1 commit into
masterfrom
tgpetrov/remove-http-module

Conversation

tgpetrov commented Aug 9, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

There is a NativeScriptHttpModule that uses Angular deprecated APIs

What is the new behavior?

  • The NativeScriptHttpModule is removed
  • @angular/http is removed from the dependencies

Related with #1842 .

BREAKING CHANGES:

  • The NativeScriptHttpModule is removed
  • @angular/http is removed from the dependencies

Migration steps:

  • If using NativeScriptHttpModule, replace with NativeScriptHttpClientModule as done here
  • as @angular/http is no longer a peerDependency of nativescript-angular, you can remove if from your dependencies

cla-bot Bot added the cla: yes label Aug 9, 2019
tgpetrov force-pushed the tgpetrov/remove-http-module branch from e837a4b to c12d2e5 Compare August 12, 2019 07:19
tgpetrov merged commit c6af21d into master Aug 12, 2019
tgpetrov deleted the tgpetrov/remove-http-module branch August 12, 2019 09:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL