FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(hmr): close modal views during livesync #7669 by VladimirAmiorkov · Pull Request #1944 · NativeScript/nativescript-angular · GitHub

fix(hmr): close modal views during livesync #7669 - #1944

Merged
VladimirAmiorkov merged 4 commits into
masterfrom
amiorkov/hmr-modals-fix
Aug 27, 2019
Merged

fix(hmr): close modal views during livesync #7669#1944
VladimirAmiorkov merged 4 commits into
masterfrom
amiorkov/hmr-modals-fix

Conversation

VladimirAmiorkov commented Aug 12, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

PR depends on this one to be release first: NativeScript/NativeScript#7679

PR Checklist

What is the current behavior?

Any opened modal views are not updated or closed during HMR livesync

What is the new behavior?

Any opened modal views are closed during HMR livesync

Fixes/Implements/Closes #[Issue Number].
#1854

VladimirAmiorkov self-assigned this Aug 12, 2019
cla-bot Bot added the cla: yes label Aug 12, 2019

Copy link
Copy Markdown
Contributor Author

test tns-core-modules#rc

1 similar comment

Copy link
Copy Markdown
Contributor Author

test tns-core-modules#rc

VladimirAmiorkov marked this pull request as ready for review August 26, 2019 10:52
VladimirAmiorkov merged commit 73d83ed into master Aug 27, 2019
VladimirAmiorkov deleted the amiorkov/hmr-modals-fix branch August 27, 2019 07:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL