tests: comment tabs tests partially - #2015
Merged
elena-p merged 2 commits intoOct 14, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
elena-p
approved these changes
Oct 14, 2019
Copy link
Copy Markdown
Contributor
Author
|
test --ignore |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Ignoring tests in favor of NativeScript/NativeScript#7925 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
test --ignore |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to the tns-core-modules animations overhaul intiative (removing Animators in favor of androidx Transitions)
Test case: navigating from Page with 3 nested frames and back crashes with IllegalArgumentException: parameter must be a descendant of this view only from these commented appium tests (does not reproduce with manual testing).
This is fixed in androidx.fragment:fragment:1.2.0 and tests must be uncommented when migrating to it.