FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: page navigation bug if there's not outlet for frame after cleari… by bellalMohamed · Pull Request #2233 · NativeScript/nativescript-angular · GitHub

/ nativescript-angular Public

fix: page navigation bug if there's not outlet for frame after cleari… - #2233

Merged
NathanWalker merged 2 commits into
NativeScript:masterfrom
bellalMohamed:master
Aug 27, 2020
ConversationCommits (2)ChecksFiles changed
Merged

fix: page navigation bug if there's not outlet for frame after cleari…#2233
NathanWalker merged 2 commits into
NativeScript:masterfrom
bellalMohamed:master

Conversation

bellalMohamed commented Aug 25, 2020

Copy link
Copy Markdown
Contributor

Fix for #2232

cla-bot Bot commented Aug 25, 2020

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @bellalMohamed.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

bellalMohamed commented Aug 26, 2020

Copy link
Copy Markdown
Contributor Author

@cla-bot check

cla-bot Bot added the cla: yes label Aug 26, 2020

cla-bot Bot commented Aug 26, 2020

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

NathanWalker merged commit 8bedc2d into NativeScript:master Aug 27, 2020

NathanWalker commented Aug 27, 2020

Copy link
Copy Markdown
Contributor

Thank you @bellalMohamed !! we'll publish a patch out with this on thursday ❤️

bellalMohamed mentioned this pull request Aug 27, 2020
Closed

NathanWalker commented Aug 27, 2020

Copy link
Copy Markdown
Contributor

@bellalMohamed published in 10.0.3 now, thanks again.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL