fix: add (empty) settings.gradle file to mark build as independent - #4996
Merged
rosen-vladimirov merged 1 commit intoOct 9, 2019
Merged
fix: add (empty) settings.gradle file to mark build as independent#4996rosen-vladimirov merged 1 commit into
rosen-vladimirov merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Solves NativeScript#4995 Adding an settings.gradle file marks the gradle build as a independent build and avoids conflicts with other gradle build
Copy link
Copy Markdown
Contributor
|
test cli-build |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
test cli-build cli-android |
Sorry, something went wrong.
rosen-vladimirov
approved these changes
Oct 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #4995
Adding an settings.gradle file marks the gradle build as a independent build and avoids conflicts with other gradle build
PR Checklist
What is the current behavior?
Build fails if a gradle build is part of the wrapping project.
What is the new behavior?
Build succeeds as expected.
Fixes/Implements/Closes #4995 .