fix: preview shouldn't start native watch - #5016
Merged
KristianDD merged 2 commits intoSep 12, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
test cli-smoke cli-preview cli-device |
Sorry, something went wrong.
KristianDD
force-pushed
the
kddimitrov/fix-preview-watches-native-changes
branch
from
02e7ca1 to
f763264
Compare
September 11, 2019 14:58
Copy link
Copy Markdown
Contributor
Author
|
test cli-smoke cli-preview cli-device |
Sorry, something went wrong.
DimitarTachev
approved these changes
Sep 12, 2019
Fatme
reviewed
Sep 12, 2019
Comment thread
lib/data/prepare-data.ts
Outdated
| if (_.isBoolean(data.watchNative)) { | ||
| this.watchNative = data.watchNative; | ||
| } | ||
| this.watch = data.watch; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Duplicated line?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Good catch. :)
Sorry, something went wrong.
Fatme
reviewed
Sep 12, 2019
Comment thread
lib/controllers/prepare-controller.ts
Outdated
| } | ||
|
|
||
| private async startNativeWatcherWithPrepare(platformData: IPlatformData, projectData: IProjectData, prepareData: IPrepareData): Promise<boolean> { | ||
| let newWatchStarted = false; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
newWatchStarted -> newNativeWatchStarted
Sorry, something went wrong.
Fatme
approved these changes
Sep 12, 2019
Copy link
Copy Markdown
Contributor
Author
|
test cli-smoke cli-preview cli-device |
Sorry, something went wrong.
KristianDD
deleted the
kddimitrov/fix-preview-watches-native-changes
branch
September 12, 2019 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When the user scans the preview barcode with both device platforms, the second one modifies the package.json to set the runtime version, which triggers a native change event. This causes an error as preview controller doesn't understand and shouldn't understand of native changes.
What is the new behavior?
Disable the native changes watch when running tns preview.
Fixes/Implements/Closes #4893