fix: pass appPath to the env from karma.conf.js - #5071
Merged
Fatme merged 1 commit intoOct 14, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
DimitarTachev
approved these changes
Oct 14, 2019
Two different webpack compilations are started on `tns test` command - the one from `karma-webpack` and the second one from `nativescript-dev-webpack`. As the karma's webpack doesn't provide appPath to the env and there is a hardcoded `appPath` inside `webpack.config.js` (to `src` for example), it works only with that hardcoded path. Rel to: #5070
Fatme
force-pushed
the
fatme/fix-unit-testing
branch
from
1f2231c to
a54ba74
Compare
October 14, 2019 06:34
Copy link
Copy Markdown
Contributor
Author
|
test cli-tests |
Sorry, something went wrong.
KristianDD
approved these changes
Oct 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two different webpack compilations are started on tns test command - the one from karma-webpack and the second one from nativescript-dev-webpack. As the karma's webpack doesn't provide appPath to the env and there is a hardcoded appPath inside webpack.config.js (to src for example), it works only with that hardcoded path.
Rel to: #5070
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].