feat: cache shouldMigrate result - #5074
Merged
KristianDD merged 2 commits intoOct 15, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Fatme
reviewed
Oct 14, 2019
Comment thread
lib/controllers/migrate-controller.ts
Outdated
| private async getCachedShouldMigrate(projectDir: string, platform: string): Promise<boolean> { | ||
| let cachedShouldMigrateValue = null; | ||
|
|
||
| const cashedHash = await this.$jsonFileSettingsService.getSettingValue(getHash(`${projectDir}${platform.toLowerCase()}`)); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
cashedHash -> cachedHash
Sorry, something went wrong.
Fatme
reviewed
Oct 14, 2019
Comment thread
lib/controllers/migrate-controller.ts
Outdated
| let cachedShouldMigrateValue = null; | ||
|
|
||
| const cashedHash = await this.$jsonFileSettingsService.getSettingValue(getHash(`${projectDir}${platform.toLowerCase()}`)); | ||
| const packageJsonShasum = await this.getPachageJsonHash(projectDir); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
packageJsonShasum -> packageJsonHash
Sorry, something went wrong.
Fatme
approved these changes
Oct 14, 2019
Copy link
Copy Markdown
Contributor
Author
|
test cli-smoke |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].
Rel to #5096