fix: pass allowProvisioningUpdates to xcodebuild only when building for device - #5077
Merged
Fatme merged 2 commits intoOct 16, 2019
Merged
fix: pass allowProvisioningUpdates to xcodebuild only when building for device#5077Fatme merged 2 commits into
Fatme merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…or device The `-allowProvisioningUpdates` option is passed to `xcodebuild` no matter if building for device or for simulator. According to the documentation of `xcodebuild`: ``` Allow xcodebuild to communicate with the Apple Developer website. For automatically signed targets, xcodebuild will create and update profiles, app IDs, and certificates. For manually signed targets, xcodebuild will download missing or updated provisioning profiles. Requires a developer account to have been added in Xcode's Accounts preference pane. ``` It seems it shouldn't be passed when building for simulator.
rosen-vladimirov
approved these changes
Oct 15, 2019
Copy link
Copy Markdown
Contributor
Author
|
test cli-smoke |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
test cli-device |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
test cli-device |
Sorry, something went wrong.
2 similar comments
Copy link
Copy Markdown
Contributor
Author
|
test cli-device |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
test cli-device |
Sorry, something went wrong.
KristianDD
approved these changes
Oct 15, 2019
Copy link
Copy Markdown
Contributor
Author
|
test cli-device |
Sorry, something went wrong.
2 similar comments
Copy link
Copy Markdown
Contributor
Author
|
test cli-device |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
test cli-device |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I'm merging the PR as device tests are green http://nsbuild01.telerik.com:8080/build/job/pr-cli-device-osx/97/ |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewersAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The -allowProvisioningUpdates option is passed to xcodebuild no matter if building for device or for simulator.
According to the documentation of xcodebuild:
It seems it shouldn't be passed when building for simulator.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].