feat: support aab in run and deploy - #5078
Merged
DimitarTachev merged 1 commit intoOct 15, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
DimitarTachev
force-pushed
the
tachev/run-with-aab
branch
from
b06eb07 to
c72536f
Compare
October 15, 2019 08:34
KristianDD
reviewed
Oct 15, 2019
Comment thread
lib/definitions/build.d.ts
Outdated
KristianDD
reviewed
Oct 15, 2019
Comment thread
lib/common/mobile/android/android-application-manager.ts
Outdated
KristianDD
approved these changes
Oct 15, 2019
DimitarTachev
force-pushed
the
tachev/run-with-aab
branch
from
c72536f to
e0b4353
Compare
October 15, 2019 11:42
Copy link
Copy Markdown
Contributor
Author
|
test cli-smoke |
Sorry, something went wrong.
DimitarTachev
force-pushed
the
tachev/run-with-aab
branch
from
e0b4353 to
902d369
Compare
October 15, 2019 12:15
Copy link
Copy Markdown
Contributor
Author
|
test cli-smoke |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The run and deploy commands are not able to be executed with --aab.
What is the new behavior?
We are able to be run and deploy with --aab.
Related to: #5049