FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: replace grunt with npm scripts by edusperoni · Pull Request #6088 · NativeScript/nativescript-cli · GitHub

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .cmd  (1) .js  (5) .json  (3) .md  (2) .sh  (1) dotfile  (1) All 6 file types selected
Only manifest files
Deleted files Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
3 changes: 1 addition & 2 deletions .gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -87,5 +87,4 @@ lib/common/test-reports.xml
!lib/common/test-scripts/**
!lib/common/scripts/**
config/test-deps-versions-generated.json
!scripts/get-next-version.js
!scripts/get-npm-tag.js
!scripts/*.js
12 changes: 0 additions & 12 deletions BuildPackage.cmd

This file was deleted.

10 changes: 5 additions & 5 deletions CONTRIBUTING.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Before you submit a Pull Request, consider the following guidelines.
```bash
git clone git@github.com:NativeScript/nativescript-cli.git
```
* Run the setup script. This will initialize the git submodule, install the node dependencies and build with grunt.
* Run the setup script. This will install the node dependencies and set up the git hooks.
```bash
npm run setup
```
Expand All @@ -44,15 +44,15 @@ Before you submit a Pull Request, consider the following guidelines.
* Create your patch and include appropriate test cases.
* Build your changes locally.
```bash
./node_modules/.bin/grunt
npm run build
```
* Ensure all the tests pass.
```bash
./node_modules/.bin/grunt test
npm test
```
* Ensure that your code passes the linter.
* Ensure that your code is formatted.
```bash
./node_modules/.bin/grunt lint
npm run prettier
```
* Commit your changes following the [commit message guidelines](https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#-commit-message-guidelines) (the commit message is used to generate release notes).
```bash
Expand Down
297 changes: 0 additions & 297 deletions Gruntfile.js

This file was deleted.

2 changes: 1 addition & 1 deletion docs/build-jekyll-md.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ set -e
rm -rf docs-cli
npm install --ignore-scripts

npx grunt docs-jekyll
npm run docs-jekyll
2 changes: 2 additions & 0 deletions docs/man_pages/config/config-set.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ General | `$ ns config set <key> <value>`
* Setting whole objects is not supported. Update individual keys instead. For example, use:
`$ ns config set android.codeCache true`

<% if(isHtml) { %>

### Related Commands

Command | Description
Expand Down
Loading

Back | FazBrowse Home | New Git URL