fix: resolve compiled output from dist in bin and postinstall - #6095
Merged
NathanWalker merged 1 commit intoJul 29, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
WalkthroughThe CLI bootstrap and postinstall script now detect dist/lib and fall back to lib, allowing module resolution in both published packages and source checkouts. ChangesRuntime library resolution
Estimated code review effort: 2 (Simple) | ~10 minutes Poem 🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
edusperoni
force-pushed
the
fix/dist-entrypoints
branch
from
d26d893 to
cb3fb8d
Compare
July 29, 2026 16:08
Both resolve into lib/ relative to their own location, which stopped working when the build moved output to dist/: lib/ now holds only TypeScript, so running ./bin/tns or postinstall.js from a checkout fails with MODULE_NOT_FOUND. The published package is unaffected, since dist/ is its root and lib/ already sits next to bin/ there. Both now prefer dist/lib when it exists and fall back otherwise, which covers the checkout and the package without either needing to know which it is. The other bin entries delegate to ./tns, so they are fixed with it. npm install in a checkout runs postinstall and would hit the same failure - masked only because npm run setup passes --ignore-scripts.
NathanWalker
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
A regression from #6092. The release-script half of this went straight to main as cb3fb8db5, since it was blocking publishing; this is the remainder.
What is the current behavior?
bin/tns and postinstall.js resolve into lib/ relative to their own location:
Since the build moved output to dist/, lib/ holds only TypeScript, so from a checkout:
The published package is unaffected — dist/ is its root there, so lib/ already sits next to bin/. Only the source tree broke, which is exactly why the packaging verification on #6092 did not catch it.
npm install in a checkout runs postinstall and hits the same failure. That is masked today only because npm run setup passes --ignore-scripts.
What is the new behavior?
Both prefer dist/lib when it exists and fall back otherwise, so neither needs to know which layout it is in. The remaining bin/ entries (nativescript, ns, nsc, …) all require("./tns"), so they are fixed with it.
Verification
Not reachable from the unit suite, so both layouts were exercised directly:
Worth noting for follow-up: nothing in the suite executes bin/tns in either layout, which is why this class of bug is invisible to CI. A smoke test covering both would close that.
Summary by CodeRabbit