feat: support vitest unit tests - #6123
Conversation
Sorry, something went wrong.
WalkthroughThe CLI now supports Vitest initialization and execution for NativeScript runtime, UI, and visionOS tests. It adds dependencies, resources, Android network configuration, framework detection, command routing, and documentation while preserving the Karma flow with deprecation notices. ChangesVitest testing integration
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant TestCommandBase
participant VitestExecutionService
participant Vitest
TestCommandBase->>VitestExecutionService: detect project and validate readiness
VitestExecutionService->>Vitest: start platform-specific non-watch run
Vitest-->>VitestExecutionService: return process status
VitestExecutionService-->>TestCommandBase: complete or report failure
Possibly related PRs
Suggested reviewers: edusperoni Poem 🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agentsVerify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. Inline comments: In `@config/test-dependencies.json`: - Around line 3-22: Regenerate the generated dependency registry from config/test-dependencies.json using scripts/generate-test-deps.js, and include the resulting config/test-deps-versions-generated.json with entries for vitest, `@vitest/runner`, `@nativescript/unit-test-runner`, and `@valor/nativescript-websockets` so ns test init --framework vitest can resolve them.
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info ⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: cbfc56e8-3737-417e-9205-85df7cbd4fbd
📥 CommitsReviewing files that changed from the base of the PR and between 9322fdc and 51352d9.
📒 Files selected for processing (16)- config/test-dependencies.json
- docs/man_pages/project/testing/test-init.md
- lib/bootstrap.ts
- lib/commands/test-init.ts
- lib/commands/test.ts
- lib/common/declarations.d.ts
- lib/constants.ts
- lib/definitions/project.d.ts
- lib/services/test-initialization-service.ts
- lib/services/vitest-execution-service.ts
- resources/test/example.vitest.js
- resources/test/example.vitest.ts
- resources/test/network_security.xml
- resources/test/test-main.vitest.js
- resources/test/test-main.vitest.ts
- resources/test/vitest.config.mts
Sorry, something went wrong.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agentsVerify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. Inline comments: In `@docs/man_pages/project/testing/test-visionos.md`: - Line 46: Insert a blank line immediately before the `<% } %>` template directive in the Markdown table section so the table is terminated before the directive and markdownlint MD056 no longer treats it as a table row.
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info ⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 10473ce5-0101-4493-9052-9b4c7954cabe
📥 CommitsReviewing files that changed from the base of the PR and between 51352d9 and 764e577.
📒 Files selected for processing (9)- docs/man_pages/project/testing/test-android.md
- docs/man_pages/project/testing/test-init.md
- docs/man_pages/project/testing/test-ios.md
- docs/man_pages/project/testing/test-visionos.md
- docs/man_pages/project/testing/test.md
- lib/bootstrap.ts
- lib/commands/test-init.ts
- lib/commands/test.ts
- resources/test/vitest.config.mts
- lib/bootstrap.ts
- resources/test/vitest.config.mts
- docs/man_pages/project/testing/test-init.md
- lib/commands/test-init.ts
Sorry, something went wrong.
| [test init](test-init.html) | Configures your project for unit testing with a selected framework. | ||
| [test android](test-android.html) | Runs the tests in your project on Android devices or native emulators. | ||
| [test ios](test-ios.html) | Runs the tests in your project on iOS devices or the iOS Simulator. | ||
| <% } %> |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
End the Markdown table before the template directive.
Line 46 is parsed as a one-column table row. markdownlint-cli2 reports MD056. Insert a blank line before <% } %>.
Proposed fix [test ios](test-ios.html) | Runs the tests in your project on iOS devices or the iOS Simulator.
+
<% } %>[warning] 46-46: Table column count
Expected: 2; Actual: 1; Too few cells, row will be missing data
(MD056, table-column-count)
🤖 Prompt for AI AgentsVerify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/man_pages/project/testing/test-visionos.md` at line 46, Insert a blank line immediately before the `<% } %>` template directive in the Markdown table section so the table is terminated before the directive and markdownlint MD056 no longer treats it as a table row.
Source: Linters/SAST tools
Sorry, something went wrong.
Support Vitest as first class default option on unit testing. Other options are still options as well on init.
Companion for NativeScript/nativescript-unit-test-runner#80
Summary by CodeRabbit
New Features
Documentation
Bug Fixes