FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: avoid duplicate modules from tns-core-modules and @nativescript/core by DimitarTachev · Pull Request #1103 · NativeScript/nativescript-dev-webpack · GitHub

This repository was archived by the owner on Aug 7, 2021. It is now read-only.

fix: avoid duplicate modules from tns-core-modules and @nativescript/core - #1103

Merged
rosen-vladimirov merged 2 commits into
masterfrom
tachev/fix-angular-scoped-packages
Dec 4, 2019
Merged

fix: avoid duplicate modules from tns-core-modules and @nativescript/core#1103
rosen-vladimirov merged 2 commits into
masterfrom
tachev/fix-angular-scoped-packages

Conversation

Copy link
Copy Markdown
Contributor

The AngularCompilerPlugin is resolving the files based on the paths property from the tsconfig and we have to unify the core modules package name in order to avoid duplicate modules causing app crashes on Android.

PR Checklist

What is the current behavior?

vendor.js contains both the @nativescrip/core/ui/application and the proxy tns-core-modules/ui/application in Angular apps with short imports support in their tsconfig:

"paths": {
    "*": [
        "./node_modules/tns-core-modules/*",
        "./node_modules/*"
    ],
    "~/*": [
        "app/*"
    ]
}

What is the new behavior?

We are processing the tsconfig paths and unifying the core modules package name in order too keep a single package name in the generated code.

Related to: may failing Angular related e2e tests

cla-bot Bot added the cla: yes label Dec 3, 2019
…core causing app crashes on Android

The AngularCompilerPlugin is resolving the files based on the `paths` property from the tsconfig and we have to unify the core modules package name in order to avoid duplicate modules.
DimitarTachev force-pushed the tachev/fix-angular-scoped-packages branch from ba9b772 to b74b231 Compare December 3, 2019 14:38

Copy link
Copy Markdown

test --webpack-apps

Copy link
Copy Markdown
Contributor Author

test --webpack-apps

rosen-vladimirov merged commit e4bc3c5 into master Dec 4, 2019
rosen-vladimirov deleted the tachev/fix-angular-scoped-packages branch December 4, 2019 12:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL