This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: remove mangle excludes - #461
Merged
sis0k0 merged 2 commits intoMar 13, 2018
Merged
sis0k0 merged 2 commits into
sis0k0 merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Depends on: NativeScript/android#923 NativeScript/NativeScript#5257 BREAKING CHANGES: `uglifyMangleExcludes` is no longer exported from the nativescript-dev-webpack plugin and shouldn't be used in the webpack configuration. Before: ``` // webpack.config.js // ... uglifyOptions: { mangle: { reserved: nsWebpack.uglifyMangleExcludes }, // ... } ``` After: ``` // webpack.config.js // ... uglifyOptions: { // ... } ```
Copy link
Copy Markdown
Contributor
Author
|
test |
Sorry, something went wrong.
MartoYankov
approved these changes
Mar 13, 2018
sis0k0
added a commit
that referenced
this pull request
Mar 22, 2018
reverts the breaking change caused by #461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
NativeScript/android#923
NativeScript/NativeScript#5257
BREAKING CHANGES:
uglifyMangleExcludes is no longer exported from the
nativescript-dev-webpack plugin and shouldn't be used in the webpack
configuration.
Before:
// webpack.config.js // ... uglifyOptions: { mangle: { reserved: nsWebpack.uglifyMangleExcludes }, // ... }After:
// webpack.config.js // ... uglifyOptions: { // ... }