FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: angular tsconfig wrong @demo/shared path by agonper · Pull Request #25 · NativeScript/plugin-seed · GitHub

/ plugin-seed Public template

fix: angular tsconfig wrong @demo/shared path - #25

Open
agonper wants to merge 1 commit into
NativeScript:mainfrom
agonper:ng-tsconfig
Open

fix: angular tsconfig wrong @demo/shared path#25
agonper wants to merge 1 commit into
NativeScript:mainfrom
agonper:ng-tsconfig

Conversation

agonper commented Mar 22, 2022

Copy link
Copy Markdown
Contributor

Error description

Angular demo build cannot find files under @demo/shared scope

Steps to reproduce

  1. Download plugin seed
  2. Setup and config
  3. Add a plugin
  4. Try to build the Angular demo app
  5. Webpack will fail with the following error:

cla-bot Bot added the cla: yes label Mar 22, 2022

Copy link
Copy Markdown
Contributor

Thanks @agonper there's one other adjustment the tools need with latest updates to ensure the angular app's tsconfig is correct, it should instead annotate along with each added package like this for example:

{
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
    "paths": {
      "~/*": ["src/*"],
      "@demo/shared": ["tools/demo/index.ts"],
      "@nativescript/*": ["packages/*"]
    }
  },
  "files": ["./references.d.ts", "./src/main.ts", "./src/polyfills.ts"],
  "include": ["../../packages/**/references.d.ts", "../../**/*.android.ts", "../../**/*.ios.ts"]
}

That would allow natural livesync changes with Angular demo.
I'll add this adjustment in the tools this week.

agonper commented Mar 23, 2022

Copy link
Copy Markdown
Contributor Author

You're welcome @NathanWalker. I'm happy to help 🙂 .

That would allow natural livesync changes with Angular demo.

I noticed that too. Now with Ivy it should no longer be necessary to pre-build Angular plugins for live sync, right? That would be an enormous DX boost!

Looking forward seeing that adjustment! Thanks for making NativeScript better every day 😄

Copy link
Copy Markdown
Contributor

Correct! Yes that should allow the angular demo to work/livesync like the vanilla demo. Thanks for the kind words 🤗

jnorkus commented Apr 20, 2022

Copy link
Copy Markdown

Any progress on this issue? I have tried implementing the tsconfig changes but there are still errors resolving modules.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL