FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

(pdf) upate android libraries by madmas · Pull Request #645 · NativeScript/plugins · GitHub

/ plugins Public

(pdf) upate android libraries - #645

Open
madmas wants to merge 5 commits into
NativeScript:mainfrom
madmas:pdf_upate-android-libraries
ConversationCommits (5)ChecksFiles changed
Open

(pdf) upate android libraries#645
madmas wants to merge 5 commits into
NativeScript:mainfrom
madmas:pdf_upate-android-libraries

Conversation

madmas commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

As Google requires all apps to take care for the 16kb page size alignment, this PR updates the libraries used in PDF plugin to do so.

Repositories used:

Created during Hackergarten Dortmund Sept. 2025 .

madmas force-pushed the pdf_upate-android-libraries branch from 22c54cd to e552af1 Compare September 4, 2025 21:29
madmas mentioned this pull request Sep 4, 2025
Merged
madmas force-pushed the pdf_upate-android-libraries branch from a32c633 to 0a9cf82 Compare September 4, 2025 21:50
NathanWalker marked this pull request as ready for review September 5, 2025 18:35

madmas commented Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

@NathanWalker thanks a lot picking up on this and pushing a release out there - that helps with testing.

testing is actually the reason i kept the MR it in DRAFT, I'm on it and stumbled into a problem when using the updated version with angular. keep looking into it.
did you successfully integrate the new version yet?

madmas commented Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

Tests (Published version 2.2.0):

Android 12 / Pixel 3a ✅ (Angular and vanilla)
Android 16 / Pixel 8 ✅ (Angular and vanilla)
Android 12 / Samsung M51 ✅
Android 16-Beta / Pixel 9a ✅
Android 15 / samsung s24 ✅

Next thing is to validate with Google that the 16KB requirement is fulfilled.

madmas commented Sep 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Also, on Google Play Console, the libraries from this plugin are not shown as incompliant anymore 👍 (virtuall) also Un-drafting the PR from my side :)

This was referenced Sep 10, 2025
Closed
Open

madmas commented Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

@NathanWalker this is fine to merge from my side 👍 or do you see something thats missing?

SmailHammour commented Oct 17, 2025

Copy link
Copy Markdown

@madmas @NathanWalker Any news on this?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL