FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(build): reference the iOS LocationEssentials typings by NathanWalker · Pull Request #674 · NativeScript/plugins · GitHub

fix(build): reference the iOS LocationEssentials typings - #674

Open
NathanWalker wants to merge 1 commit into
mainfrom
fix/ios-location-typings-reference
Open

fix(build): reference the iOS LocationEssentials typings#674
NathanWalker wants to merge 1 commit into
mainfrom
fix/ios-location-typings-reference

Conversation

NathanWalker commented Aug 24, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

nx build geolocation currently fails on main with 8 errors:

packages/geolocation/index.ios.ts:55:90  - error TS2552: Cannot find name 'CLLocation'.
packages/geolocation/index.ios.ts:146:122 - error TS2304: Cannot find name 'CLLocationCoordinate2DMake'.
... (8 total)

@nativescript/types-ios v9 moved CLLocation, CLLocationCoordinate2D and CLLocationCoordinate2DMake out of objc!CoreLocation.d.ts and into objc!_LocationEssentials.d.ts. The root references.d.ts references the former but never picked up the latter, so those symbols resolve nowhere.

One line added to references.d.ts. nx build geolocation is clean afterwards.

Independent of the perms v3 work, but worth merging first — it is what makes #675 verifiable.

🤖 Generated with Claude Code

@nativescript/types-ios v9 moved CLLocation, CLLocationCoordinate2D and
CLLocationCoordinate2DMake out of objc!CoreLocation.d.ts into
objc!_LocationEssentials.d.ts, which nothing referenced. Without it
`nx build geolocation` fails with 8 "Cannot find name 'CLLocation'"
errors.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 68122526-87e8-4331-852a-f188f52ba449

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL