feat: RN TurboModule -- threading + Fabric integration, rebuilt (supersedes #46) - #72
feat: RN TurboModule -- threading + Fabric integration, rebuilt (supersedes #46)#72DjDeveloperr merged 1 commit into
Conversation
Sorry, something went wrong.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: a644f59b-cfe5-43c2-9a07-90f3ea41e7e6 You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file. Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
Matches @nativescript/react-native's existing peerDependenciesMeta convention. Without it, npm's auto-peer-install for @nativescript/react-native-screens pulled in react-native-worklets@0.11.4 (peer react-native 0.83-0.86), conflicting with the workspace's real react-native@0.79.5 (pinned transitively via react-native-node-api) and breaking `npm install` at the repo root -- this is what CI's build job runs, and it failed on PR #72 for exactly this reason.
Matches @nativescript/react-native's existing peerDependenciesMeta convention. Without it, npm's auto-peer-install for @nativescript/react-native-screens pulled in react-native-worklets@0.11.4 (peer react-native 0.83-0.86), conflicting with the workspace's real react-native@0.79.5 (pinned transitively via react-native-node-api) and breaking `npm install` at the repo root -- this is what CI's build job runs, and it failed on PR #72 for exactly this reason.
Summary
Rebuilds the React Native TurboModule and Fabric integration around generic native-component contracts. The runtime now exposes one component definition API for native view creation, props, events, commands, layout, child mounting, controller containment, and teardown.
Architecture
defineNativeComponent owns the typed JavaScript contract. Fabric delegates native lifecycle hooks to the UI runtime, while the Objective-C++ layer handles mounting transactions, layout metrics, events, commands, controller ownership, and runtime invalidation. Component implementations remain outside the runtime package.
The old specialized UIKit host surface and its process-wide view swizzling are removed. This also removes the legacy registries, batch walkers, point-fix RPCs, frame-loop hook, and specialized controller/view APIs.
Verification
Known limitation
Completion blocks declared only by Objective-C protocols still require an explicit interop.Block signature until #71 lands. Class-declared completion parameters accept ordinary closures.