fix(android): outline button styling - #154
Merged
manoldonev merged 3 commits intoMay 10, 2019
Merged
manoldonev merged 3 commits into
manoldonev merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dtopuzov
approved these changes
May 10, 2019
dtopuzov
approved these changes
May 10, 2019
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NativeScript/NativeScript#7055 (comment) introduced a regression for the styling of outline buttons in Android.
We are leveraging the new androidElevation property introduced with NativeScript/NativeScript#7136 to address this theming issue.