This repository was archived by the owner on Mar 21, 2019. It is now read-only.
fix(label): text wrapping inside flexbox layout - #121
Merged
manoldonev merged 5 commits intoMay 8, 2018
Merged
manoldonev merged 5 commits into
manoldonev merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…tns-core-modules-widgets into mdonev/tnslabel-layout-fix
manoldonev
commented
May 4, 2018
| // might result in increased height e.g. text that could be shown on one line for larger | ||
| // width needs to be wrapped in two when width is reduced. | ||
| // As a result we cannot unconditionally measure with EXACTLY the current measured height | ||
| int childHeightMeasureSpec = getChildMeasureSpec(this.getMeasuredHeightAndState(), |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Basically this is the Android version of the fix from this PR NativeScript/NativeScript#5781
Sorry, something went wrong.
ADjenkov
approved these changes
May 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Widget part of) Fixes NativeScript/NativeScript#4834
(Widget part of) Fixes NativeScript/NativeScript#3834
NOTE: Also fixes iOS 11 specific scenarios with text wrapping outside flexbox.