| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
The Async class also is the only one to make exclusive calls to e.printStackTrace however I would argue that should not be used and instead a standard log as described here: I can modify to use Log per core team suggestion so leaving commented in these changes for now. |
Sorry, something went wrong.
|
Hey @NathanWalker, Could you please replace e.pinrtStackTrace() with Log and clean up the comments and formatting in order to proceed with merging? Thank you! |
Sorry, something went wrong.
|
@vchimev I have updated to use Log now and formatted - not sure why it shows entire file formatted though. Looks like all other files are formatted using 4 spaces which this one is now as well. Was it not properly formatted on master originally using Tabs? Lemme know if something else I need to do with formatting on this Async.java file but other than that should be good? |
Sorry, something went wrong.
|
Thank you, @NathanWalker! I just replaced Log.v() with Log.e() and also checked out the formatting. On its way to master. |
Sorry, something went wrong.
This reverts commit ce45e75.
| Back | FazBrowse Home | New Git URL |
PR Checklist
What is the current behavior?
Android can become unstable due to improper error handling around async requests.
What is the new behavior?
Better error condition handling which allow core modules to handle more appropriately.