feat(tvos): build Apple TV V8 release variants - #8
NathanWalker merged 1 commit into
Conversation
Sorry, something went wrong.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: d49f8b64-6e5d-4f89-8ee3-b65db99f51c0 You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file. Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
Same V8 build inputs as -7 plus the arm64-tvdevice and arm64-tvsimulator variants (NativeScript/v8-buildscripts#8), which download_v8.sh --tvos installs for the tvOS runtime build. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Same V8 build inputs as -7 plus the arm64-tvdevice and arm64-tvsimulator variants (NativeScript/v8-buildscripts#8), which download_v8.sh --tvos installs for the tvOS runtime build.
Add arm64 tvOS device and simulator release variants to the current V8 source-build matrix. Keep the five existing Apple GN argument sets unchanged.
Validation
Both V8 14.9.207.39 variants built and packaged. Actual isolate.o compiler commands contain -O3 and -DNDEBUG; device object auditing confirms TVOS/minimum 13.0. Both matrix regression tests passed. The resulting archives built and ran the current NativeScript tvOS simulator app.
Reproduce
Revision-pinned reviewer setup builds the companion stack in an isolated workspace. It includes commands, requirements, dependency pins and physical-device limitations. No binary artifacts or private development paths are committed.
This PR contains one commit, 36a75935c032f8ce0715e05ef112a42350d8dce1, changing 4 files against 9dfc18bfac6e2c3e49253ab88c68c0a4ae289371. Its exported patch reproduces the committed tree from a fresh base index.
The source-built runtime was validated in the prepared runtime checkout; companion clones, native helpers, Canvas and clean npm installation were validated in a separate workspace on the same Mac. A second machine and one uninterrupted cold all run have not been tested.