Repository navigation
Beanchmark grid search - #323
Merged
sylvchev merged 35 commits intoJan 26, 2023
Merged
sylvchev merged 35 commits into
sylvchev merged 35 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Copy link
Copy Markdown
Member
|
I merged the PR for the grid search in evaluation. Could you rebase this branch to avoid double commit? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@carraraig Could you check the errors in test_benchmark? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
To solve this we need to have in each pipeline.yml the key param_grid: None If we don't want to use the grid search. |
Sorry, something went wrong.
sylvchev
reviewed
Jan 26, 2023
Comment thread
moabb/pipelines/utils.py
Outdated
Comment thread
examples/pipelines_grid/EN.yml
Comment thread
examples/pipelines_grid/EN_grid.yml
Comment thread
examples/plot_benchmark_grid_search.py
Outdated
Comment thread
examples/plot_benchmark_grid_search.py
Outdated
Comment thread
examples/plot_benchmark_grid_search.py
Outdated
Comment thread
moabb/tests/test_pipelines/CSP.yml
Outdated
sylvchev
approved these changes
Jan 26, 2023
Comment thread
moabb/pipelines/utils.py
Outdated
Comment thread
moabb/pipelines/utils.py
Outdated
Comment thread
moabb/pipelines/utils.py
Outdated
Copy link
Copy Markdown
Member
|
thanks @carraraig ! This is really a nice addition! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grid search implementation in Benchmark function