FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

CodeCarbon by carraraig · Pull Request #350 · NeuroTechX/moabb · GitHub

  1. NeuroTechX
  2. moabb

Repository navigation

CodeCarbon - #350

Merged
sylvchev merged 44 commits into
NeuroTechX:developfrom
carraraig:CodeCarbon
Mar 28, 2023
ConversationCommits (44)ChecksFiles changed
Merged

CodeCarbon#350
sylvchev merged 44 commits into
NeuroTechX:developfrom
carraraig:CodeCarbon

Conversation

carraraig commented Mar 21, 2023

Copy link
Copy Markdown
Collaborator

Added Codecarbon output for each pipeline. We need to change the format of the column of emission in scientific format.
@sylvchev do you know where to change this option?

carraraig requested a review from sylvchev March 21, 2023 14:52

carraraig commented Mar 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

The package codecarbon need to be added, @bruAristimunha can you add it using poetry?

carraraig commented Mar 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

At the moment seems that the codetracker is not reinitialize at each computation. Try to solve

sylvchev reviewed Mar 21, 2023
View reviewed changes
Comment thread moabb/analysis/results.py Outdated
Comment thread moabb/analysis/results.py Outdated
Comment thread moabb/evaluations/evaluations.py Outdated
Comment thread moabb/evaluations/evaluations.py Outdated
Comment thread moabb/evaluations/evaluations.py Outdated
Comment thread moabb/tests/analysis.py Outdated
Comment thread moabb/tests/analysis.py Outdated
Comment thread moabb/tests/analysis.py Outdated
Comment thread moabb/tests/evaluations.py Outdated
Comment thread pyproject.toml Outdated
carraraig and others added 12 commits March 22, 2023 13:42
Update moabb/analysis/results.py
dea10a5 
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Update moabb/analysis/results.py
155cc58 
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Update moabb/evaluations/evaluations.py
bed84b3 
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Update moabb/evaluations/evaluations.py
62ca1b2 
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Update moabb/evaluations/evaluations.py
da906f4 
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Update moabb/tests/analysis.py
d397ec8 
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Update moabb/tests/analysis.py
60bbd38 
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Update moabb/tests/analysis.py
7e281cc 
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Update moabb/tests/analysis.py
a755897 
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Update moabb/tests/evaluations.py
1789843 
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Update pyproject.toml
1f137d3 
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Merge branch 'NeuroTechX:develop' into CodeCarbon
30c6476
bruAristimunha approved these changes Mar 23, 2023
View reviewed changes

bruAristimunha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @carraraig and @sylvchev,

Looks amazing for me =)

sylvchev commented Mar 24, 2023

Copy link
Copy Markdown
Member

I updated the requirements and pyproject.toml. There is still an error in the documentation due to the update of Sphinx version. Once this is solved, we could merge!

sylvchev commented Mar 28, 2023

Copy link
Copy Markdown
Member

The doc build error is strange, I could not reproduce it locally. Maybe we could merge this PR and I'll open a new one to make some correction on the documentation (there are some error and warning) to further investigate this error.

carraraig commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator Author

I agree with this proposal @sylvchev

sylvchev merged commit c9c4043 into NeuroTechX:develop Mar 28, 2023

sylvchev commented Mar 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

thanks @bruAristimunha and @carraraig, it so amazing to have carbon footprint integrated in MOABB.

bruAristimunha commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator

Super cool!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sylvchev sylvchev left review comments
bruAristimunha bruAristimunha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL