Restore Biome checks for JavaScript sources - #567
Conversation
Sorry, something went wrong.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Sorry, something went wrong.
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Aug 26, 2026 1:39p.m. | Review ↗ | |
| Secrets | Aug 26, 2026 1:39p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Sorry, something went wrong.
| @@ -70,7 +71,7 @@ const SpaceInvaders = (() => { | |||
| } | |||
|
|
|||
| function _onUpdate() { | |||
There was a problem hiding this comment.
`_onUpdate` has a cyclomatic complexity of 6 with "medium" risk
A function with high cyclomatic complexity can be hard to understand and
maintain. Cyclomatic complexity is a software metric that measures the number of
independent paths through a function. A higher cyclomatic complexity indicates
that the function has more decision points and is more complex.
Sorry, something went wrong.
| @@ -79,7 +80,7 @@ window.addEventListener("keydown", initAudio, { once: true }); | |||
|
|
|||
| function playSound(type) { | |||
There was a problem hiding this comment.
`playSound` has a cyclomatic complexity of 6 with "medium" risk
A function with high cyclomatic complexity can be hard to understand and
maintain. Cyclomatic complexity is a software metric that measures the number of
independent paths through a function. A higher cyclomatic complexity indicates
that the function has more decision points and is more complex.
Sorry, something went wrong.
| osc.stop(now + 1.5); | ||
| } else if (type === "secret") { | ||
| } else { | ||
| playLayeredSound(type, osc, now); |
There was a problem hiding this comment.
'playLayeredSound' was used before it was defined
It is recommended to use a variable only after it is defined as it might produce errors at runtime.
Sorry, something went wrong.
|
|
||
| // biome-ignore lint/correctness/noUnusedVariables: Used outside this classic script. | ||
| function toggleTheme() { | ||
| playSound("click"); |
There was a problem hiding this comment.
'playSound' is not defined
Variables that aren't defined, but accessed may throw reference errors at runtime.
NOTE: In browser applications, DeepSource recommends the use of ESModules over regular text/javascript scripts.
Using variables that are injected by scripts included in an HTML file is currently not supported.
Sorry, something went wrong.
|
|
||
| // biome-ignore lint/correctness/noUnusedVariables: Used outside this classic script. | ||
| function scrollToRandomUser() { | ||
| playSound("click"); |
There was a problem hiding this comment.
'playSound' is not defined
Variables that aren't defined, but accessed may throw reference errors at runtime.
NOTE: In browser applications, DeepSource recommends the use of ESModules over regular text/javascript scripts.
Using variables that are injected by scripts included in an HTML file is currently not supported.
Sorry, something went wrong.
|
Following up on the one caveat in the description: I've now exercised the two refactored areas in a real browser (headless Chromium, local build of this branch against aa10215). Audio — with a genuine click to start the AudioContext, I traced every createOscillator/createGain call, the oscillator type, each frequency and gain value, and the start/stop offsets, for click, levelUp, secret, restore, and an unrecognised type. All five traces are identical on both builds, so the LAYERED_SOUND_CONFIGS lookup builds exactly the same audio graph the previous branch chain did. Space Invaders — the game boots and renders, and under real key presses ArrowLeft/ArrowRight still drive setVelocityX(-400)/(+400), no input leaves it at 0, and Space still fires bullets. Same on both builds. No console errors or failed requests beyond the ones the pre-change build already produces. The five DeepSource comments above are all outdated — each was raised against an intermediate commit and answered by the next one; both analyzers are green on f78699ab. |
Sorry, something went wrong.
Reviewers
At least 1 approving review is required to merge this pull request.
Fixes #406.
Summary
without changing their runtime bindings
cleanups without weakening Biome's recommended rules
threshold by consolidating layered audio sequences and extracting
Space Invaders movement and bullet access
window.* convention
Restoring the JavaScript include exposes 32 warnings that Super-Linter 8.7.0
treats as errors. The targeted suppressions only cover declarations that Biome
cannot see being consumed outside their source file; unrelated unused
declarations remain protected by the rule.
Scope
Biome still reports 20 informational diagnostics: 16 useTemplate
suggestions, two useParseIntRadix suggestions, and two configuration
migration notices. They do not fail --error-on-warnings and are left for
separate style/version work.
This change also leaves the pre-commit warning policy and unpinned local Biome
dependency unchanged. Aligning those with Super-Linter's pinned Biome 2.5.0
should be handled together as a follow-up.
Testing
--error-on-warnings --no-errors-on-unmatched
Super-Linter flags
state/type cases and seven Space Invaders update scenarios
Manual browser interaction was not run in this environment.