FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: node stability improvements & design fixes by corn-potage · Pull Request #663 · NiceNode/nice-node · GitHub

This repository was archived by the owner on Jan 6, 2026. It is now read-only.
/ nice-node Public archive

fix: node stability improvements & design fixes - #663

Merged
jgresham merged 117 commits into
mainfrom
fix/node-status-stability
Sep 19, 2024
ConversationCommits (117)ChecksFiles changed
Merged

fix: node stability improvements & design fixes#663
jgresham merged 117 commits into
mainfrom
fix/node-status-stability

Conversation

corn-potage commented Sep 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Member
  • Added starting and stopping states to button, disabled states to stop user from interrupting
  • Replaced advanced options with show other node types on add node screen
  • Added update modal, added simple modal mode
  • Changed OP static ports to dynamic
  • Refactored start and stop node code
  • Modified certain buttons to have different cursors
  • Decreased shadow on popup on chart
  • Changed checkbox to match spec
  • Info icon changed to transparent black
  • Refactored sync status (getStatusObject handles multiple states)
  • Added sync status and sync progress to client cards
  • Added % support and minute/seconds display on ProgressBar
  • Fixed client card heights
  • Moved controller info under dev mode
  • Fixed node version display
  • 1 client screen now shows 100% width
  • Added dark mode art to onboarding flow
  • Link color fixed for dark mode
  • Added tab deeplink support (notifications preference), and not display tabs if only 1 item
  • Fixed sidebar background color
  • Notifications number on sidebar is now cleared when all notifications are marked as read
  • ThemeContext added to allow us to retrieve theme status everywhere in the app
  • Major refactoring, modifications on NodePackageScreen, NodeScreen, SidebarNodeItemWrapper to optimize, align and display same status
  • Support external node check and compare CL execution payload and EL for more robust isSyncing status
  • Check and stop node package if all nodes are stopped manually from NodeScreen
  • Change Sync sub-status of In Progress... to Catching up if all nodes have finished synchronizing at least once
  • RpcExecuteTranslation modified to support specific node spec, and retrieve needed data for different node types
  • Simplified front-end polling to rely on node/node package 'running' status (@jgresham, need confirmation if this is ok)
  • If user clicks area outside of modal, it closes modal

corn-potage added 30 commits June 28, 2024 17:48
optimized node status updating for start/stop
7e202ce
improved status handling, added stopping status
b7a4804
added starting status to signify starting but before pulling podman i…
f4c73f9 
…mages
if user stops all services, stop node package too
dab35d1
added lowPeerCount, synchronized
dcfd9b0
added noConnection logic
5b60862
merge conflict resolved
ca69305
updated sidebar item to handle updated node status
e6208e4
fixed bug where starting/stopping second node with same name, affecte…
9760cdd 
…d the first node
fix status for sidebar
10b54dd
fixed node version retrieval
532fe24
continuously retrieve version, show empty string when stopped
c05c1ef
Merge branch 'main' into fix/node-status-stability
1aa0456
added CL check
f4ec4b9
fixed http issue
1a0d6fa
removed query node version, added CL check for sync status
1c62b49
logic fix
470ee9d
better logic
d5062b9
added updateNodePackage to mark nodePackage after successful initial …
bfa1ffe 
…sync
merge conflict resolved
0e5ac0f
refactored state for node package
b1348c4
cleaning
c10f153
made similar refactoring to node screen
5e5ddcc
refactored sidebarNodeItemWrapper
de93cb2
added context, and hooks to centralize queries in one place
9689b17
added context to nodePackageScreen, and added qLatestBlock
5acb3d8
changed params to object for ease
aa01c24
Revert "changed params to object for ease"
1fad3d9 
This reverts commit aa01c24.
Revert "added context to nodePackageScreen, and added qLatestBlock"
b41af63 
This reverts commit 5acb3d8.
Revert "added context, and hooks to centralize queries in one place"
85a0d43 
This reverts commit 9689b17.
corn-potage marked this pull request as ready for review September 17, 2024 16:10

jgresham commented Sep 19, 2024

Copy link
Copy Markdown
Member

ok e2e tests are passing for me now!

jgresham commented Sep 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Code looks great! All my testing so far has been good.

Great to have all these stability improvements and greater accuracy for statuses!

@corn-potage

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

jgresham Awaiting requested review from jgresham

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL