FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

nix build by wd15 · Pull Request #82 · ORNL/AdditiveFOAM · GitHub

/ AdditiveFOAM Public

nix build - #82

Open
wd15 wants to merge 7 commits into
ORNL:mainfrom
wd15:nix
ConversationCommits (7)ChecksFiles changed
Open

nix build#82
wd15 wants to merge 7 commits into
ORNL:mainfrom
wd15:nix

Conversation

wd15 commented Nov 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Adapts a Nix build for OpenFOAM 12 to OpenFOAM 10 and subsequent build of AdditiveFOAM to work with the existing build of ExaCA.

  • Tested on some of the tutorials.
  • The Nix files could be moved to envs/nix in a similar manner to the ExaCA Nix build. Let me know your preference.
  • For reference the ExaCA PR might be helpful to answer some questions
  • Using the AMB2018-02-B from the tutorials as the check for Nix. Is there a better choice as a quick check?

Edit:

  • To install from the current branch use nix develop github:wd15/AdditiveFOAM/nix. Installation instructions will only work after the merge.

Edit again:

  • Moved to envs/nix so use nix develop github:wd15/AdditiveFOAM/nix?dir=envs/nix to build

nix build
ea51734 
Adapts a Nix build for OpenFOAM 12 to OpenFOAM 10 and subsequent build
of AdditiveFOAM to work with the existing build of ExaCA.
wd15 mentioned this pull request Nov 21, 2025
Closed
colemanjs added the enhancement New feature or request label Nov 24, 2025
gknapp1 reviewed Nov 24, 2025
View reviewed changes

gknapp1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
  • I think that having the nix-related files in a separate directory, similar to the ExaCA repo, is preferred.
  • The AMB2018-02-B tutorial is good for a quick test

I wasn't able to build this following the build instructions in NIX.md (see error message in review comment). @wd15 can you provide guidance on how to troubleshoot?

Comment thread NIX.md Outdated

wd15 commented Nov 25, 2025

Copy link
Copy Markdown
Author

This only currently works with x86_64-linux. Are there other platforms that AdditiveFOAM is typically build it? Can also enable aarch66, aarch64-darwin and x86-64-darwin if you think ExaCA + dependencies would build on those platforms.

wd15 commented Nov 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Furthermore, I can cache the binaries for x86-64 once we have resolved any issues. It's free for open source projects. That should make the build very fast.

gknapp1 commented Nov 25, 2025

Copy link
Copy Markdown
Collaborator

Furthermore, I can cache the binaries for x86-64 once we have resolved any issues. It's free for open source projects. That should make the build very fast.

That's good news, the OpenFOAM nix build is quite slow. I'm building it now, so once that finishes and I can test, I'll re-review.

This only currently works with x86_64-linux. Are there other platforms that AdditiveFOAM is typically build it? Can also enable aarch66, aarch64-darwin and x86-64-darwin if you think ExaCA + dependencies would build on those platforms.

I don't know of any users typically using anything besides x86_64-linux architectures, so that seems fine for now and we can add support if we get user requests.

gknapp1 self-requested a review November 25, 2025 22:08
streeve reviewed Dec 1, 2025
View reviewed changes
Comment thread README.md

See the [installation instructions](https://ornl.github.io/AdditiveFOAM/docs/installation/#installation) in the [documentation](https://ornl.github.io/AdditiveFOAM/) for other options for building `AdditiveFOAM`.

An alternative installation mechanism is using Nix. See

streeve Dec 1, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@colemanjs would you prefer this be in the docs instead?

wd15 commented Dec 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

@gknapp1: just a note that I added cached the AdditiveFOAM binary dependencies to Cachix so the nix build should go much faster. To test it you would need to remove all the dependencies from your current Nix installation or use a different Nix store. Just using a Nix installation on a different machine is probably easier.

wd15 requested review from gknapp1 and streeve December 10, 2025 16:29

wd15 commented Dec 10, 2025

Copy link
Copy Markdown
Author

@gknapp1 @streeve This should be good now. No more changes.

gknapp1 approved these changes Dec 16, 2025
View reviewed changes

gknapp1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@wd15 thanks for the added documentation and caching implementation. This works for me and the install only took a little over a minute for the cache download (~1.6 GB).

For testing this development:

nix develop github:wd15/AdditiveFOAM/nix?dir=envs/nix --accept-flake-config

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gknapp1 gknapp1 approved these changes
colemanjs Awaiting requested review from colemanjs
streeve Awaiting requested review from streeve

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL