| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Minor rather than patch, deliberately. The public signature is unchanged, so strict semver would call this a patch — but it materially changes how many HTTP requests a call makes, and a minor keeps it out of tight pins like ~=1.12.8 while staying available to ~=1.12. Anyone on a narrow pin opts in rather than being surprised by a changed request pattern. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JKAExynd9zoKwt6rYA66EA
test_package_version_helper_reads_the_project_version asserted the literal '1.12.8', so it failed on this release for a reason unrelated to what it guards. Its job is 'does the helper report the PROJECT version', not 'is the version 1.12.8'. Now reads the expected value from pyproject.toml, so it keeps testing the helper and stops needing a hand-edit every release. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JKAExynd9zoKwt6rYA66EA
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 11827e5a-7048-4dae-bd95-9ce257efa80e Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Version bump and changelog for the #97 fix, so it can be published.
Why minor, not patch
The public signature is unchanged, so strict semver says patch. But this materially changes how many HTTP requests a call makes, and a minor keeps it out of tight pins like ~=1.12.8 while staying available to ~=1.12. Anyone on a narrow pin opts in rather than being surprised by a changed request pattern.
What ships
Users' quota consumption drops. In their favour, no code change needed — but it is a behaviour change and the changelog says so plainly.
One test fixed along the way
test_package_version_helper_reads_the_project_version asserted the literal "1.12.8", so it failed on this release for a reason unrelated to what it guards. Its job is "does the helper report the project version", not "is the version 1.12.8". It now reads the expected value from pyproject.toml — so it keeps testing the helper and stops needing a hand-edit every release.
Verification
Live smoke on the merged fix, against production:
Publishing is triggered by a published GitHub Release, so merging this does not ship to PyPI on its own.
🤖 Generated with Claude Code
https://claude.ai/code/session_01JKAExynd9zoKwt6rYA66EA