| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Thank you @babrekel, this looks good! I appreciate that you found a way to do this without breaking changes. |
Sorry, something went wrong.
|
Does it support Typed HttpClient Instance as well? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This change aims to enable consumers to use IHttpClientFactory and apply resiliency best practices described in this document without a breaking change. Consumers can now implement non-functional requirements such as:
Implementation wise, I opted not to modify the constructor as it takes an optional parameter. Adding another optional parameter is a breaking change, and mixing optional parameters with overloaded constructors is not generally recommended. Effectively seeking to minimize change.
Package wise, the dependency on Microsoft.Extensions.Http is no longer private.
I used Moq in the unit tests to mock an HTTP Client and ensure the right client is used in the right place.
Related issues that could be addressed with this change (or at least allow a workaround):
#102
#100
#91
#41
#28