Take the pull request comment token from OpenModelica-Hudson - #341
Merged
sjoelund merged 1 commit intoAug 28, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The pull request comment stage bound its GitHub token from a `github-token` credential. The credential that holds a GitHub token on the OpenModelica Jenkins is `OpenModelica-Hudson`, so point withCredentials at that one and say so in the parameter description and the README. Nothing else changes: the token is still exposed to pr-report.py as GITHUB_TOKEN, and a run without the credential still writes and publishes the report with the summary in the build log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request comment stage binds its GitHub token from a github-token
credential:
The credential that holds a GitHub token on the OpenModelica Jenkins is
OpenModelica-Hudson, so this points withCredentials at that one instead, and
updates the two places that name the credential in prose: the
pull_request_comment parameter description and the README section on
--comment.
Nothing else changes. The token still reaches pr-report.py as GITHUB_TOKEN,
and a run without the credential still writes and publishes the report, with the
summary in the build log.
Generated with Claude Code