Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…y for the same type Fixes #236
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves the method redefinition/precompilation conflict when both Makie and ControlPlots are loaded by introducing an explicit plotting-backend dispatch layer in VortexStepMethod.plot_* APIs (Fixes #236).
Changes:
- Added PlotBackend dispatch types plus set_plot_backend! and wrapper methods that route plotting calls through an active backend.
- Updated Makie and ControlPlots extensions to implement plotting methods with an additional backend-dispatch argument.
- Initialized a default active backend from each extension on load.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/VortexStepMethod.jl | Introduces backend dispatch types, backend selection state, and wrapper routing for plotting entry points. |
| ext/VortexStepMethodMakieExt.jl | Moves Makie plotting methods onto backend-dispatched signatures and sets Makie as the default backend on extension init. |
| ext/VortexStepMethodControlPlotsExt.jl | Moves ControlPlots plotting methods onto backend-dispatched signatures and sets ControlPlots as the default backend on extension init. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
ext/VortexStepMethodMakieExt.jl
Outdated
Comment thread
ext/VortexStepMethodControlPlotsExt.jl
Outdated
Comment thread
ext/VortexStepMethodMakieExt.jl
Comment thread
ext/VortexStepMethodControlPlotsExt.jl
Comment thread
ext/VortexStepMethodControlPlotsExt.jl
Outdated
Comment thread
src/VortexStepMethod.jl
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
📢 Thoughts on this report? Let us know! |
Sorry, something went wrong.
1-Bart-1
pushed a commit
that referenced
this pull request
Jul 1, 2026
…y for the same type (#237) - Added PlotBackend dispatch types plus set_plot_backend! and wrapper methods that route plotting calls through an active backend. - Updated Makie and ControlPlots extensions to implement plotting methods with an additional backend-dispatch argument. - Initialized a default active backend from each extension on load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #236