x86 crashes #29
Description
07-04 13:50:24.641 15470-15470/com.example.ottylab.bitzenyminer E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.example.ottylab.bitzenyminer, PID: 15470
java.lang.UnsatisfiedLinkError: dlopen failed: /data/app/com.example.ottylab.bitzenyminer-1/lib/x86/libbitzenymininglibrary.so: has text relocations
at java.lang.Runtime.loadLibrary0(Runtime.java:989)
at java.lang.System.loadLibrary(System.java:1530)
at com.example.ottylab.bitzenymininglibrary.BitZenyMiningLibrary.<clinit>(BitZenyMiningLibrary.java:11)
at com.example.ottylab.bitzenyminer.MainActivity.onCreate(MainActivity.java:70)
at android.app.Activity.performCreate(Activity.java:6679)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1118)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2618)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2726)
at android.app.ActivityThread.-wrap12(ActivityThread.java)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1477)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6119)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)
Activity
OttyLab commented on Jul 5, 2018
Currently, x86 library includes TEXTREL entry in it. From Android API23, TEXTREL is prohibited and crash happens.
To fix this issue, there's 3 approaches
I'll try 1. first.
OttyLab commented on Jul 16, 2018
sha2-x86.S includes .data like this;
Accessing .data code will produce TEXTREL and Android OS refuses to load.
As a fix, I propose that pushing all data into stack on the exposed function call, then popping all data on return.
#29 Update libcpuminer to enable x86 TEXTREL workaround
Merge pull request #30 from OttyLab/update-libcpuminer
OttyLab commented on Jul 16, 2018
@cryptozeny
master branch merges a workaround for x86. If you have time, could you try it ? (git submodule deinit is required, I suppose)
In this workaround, sha2-x86.S is not used (approach 2.). yescrypt does not use this, so there's no performance impact on bitzeny mining.
Fixing the assembly code would take much time. When I have time, I'll try.
cryptozeny commented on Jul 17, 2018
great! i will try it sooner. now i am upgradig cpuminer yescrypt0.5 to yesPower0.5. it boosts hashrate about 3~10%. could you update the cpuminer after its upgrading? 😅
OttyLab commented on Jul 18, 2018
@cryptozeny
Of course. Which code base can I use?
(At least, I need to change the code base from https://github.com/bitzeny/cpuminer to https://github.com/BitzenyCoreDevelopers/cpuminer 😄 )
#29: use x86 no textrel library
Merge pull request #31 from OttyLab/use-notextrel-library
OttyLab commented on Jul 22, 2018
@cryptozeny
I've updated the assembly code and master branch fixes the x86 issue. If you find some issue, please let me know.
(I must admit that the assembly code is not efficient because it needs to push some values to the stack and it would affect performance.)
OttyLab commented on Jul 24, 2018
#32 replaces the cpuminer library
cryptozeny commented on Jul 25, 2018
sorry for late answer 😅 now i am working on cpuminer-yesPower and its almost done. it boosts 2~10% hash. currently it based on macchky's one. i think its not so far from yours. can it be merged into this app?
cryptozeny commented on Jul 25, 2018
sadly new yespower doesn't support 32bit arv7l (no neon arm), however the dev of yespower said it will be supported next release. also my cpuminer support both of yespower and old yescrypt.
cryptozeny commented on Jul 25, 2018
https://gist.github.com/cryptozeny/a249d37066fd84b15b3dc1273558520e
and it supports also another coin such as yenten, koto, wavi using yescrypt.